Hello Alon Bar-Lev,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/13474
to review the following change.
Change subject: build: use embedded gettext
......................................................................
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it externally
Change-Id: I1e6c05b7a6f9aa177ddf572eac98f104e6bef605
Signed-off-by: Alon Bar-Lev <[email protected]>
---
M .gitignore
M Makefile.am
M configure.ac
M ovirt-log-collector.spec.in
4 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector
refs/changes/74/13474/1
diff --git a/.gitignore b/.gitignore
index 89f3a0e..159972c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,6 +14,8 @@
config.sub
ABOUT-NLS
+intl
+
tmp.*
*.pyc
*.pyo
diff --git a/Makefile.am b/Makefile.am
index c00305c..935e5ec 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -38,6 +38,7 @@
$(NULL)
SUBDIRS = \
+ intl \
po \
src \
$(NULL)
diff --git a/configure.ac b/configure.ac
index 63039f5..43eec4c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,7 +35,7 @@
AC_USE_SYSTEM_EXTENSIONS
AM_INIT_AUTOMAKE
AM_GNU_GETTEXT_VERSION([0.17])
-AM_GNU_GETTEXT([external])
+AM_GNU_GETTEXT
AC_ARG_ENABLE(
[python-syntax-check],
@@ -81,6 +81,7 @@
src/sos/Makefile
src/sos/plugins/Makefile
src/helper/Makefile
+ intl/Makefile
po/Makefile.in
])
AC_OUTPUT
diff --git a/ovirt-log-collector.spec.in b/ovirt-log-collector.spec.in
index 9949033..1d05256 100644
--- a/ovirt-log-collector.spec.in
+++ b/ovirt-log-collector.spec.in
@@ -29,13 +29,11 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}
BuildArch: noarch
-Requires: gettext
Requires: python
Requires: python-dateutil
Requires: python-lxml
Requires: ovirt-engine-sdk
Requires: sos
-BuildRequires: gettext-devel
BuildRequires: python2-devel
%description
--
To view, visit http://gerrit.ovirt.org/13474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e6c05b7a6f9aa177ddf572eac98f104e6bef605
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
