Eli Mesika has posted comments on this change.
Change subject: gluster: Introducing GlusterFeatureSupported
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1340: GlusterFsStorageEnabled(421),
Line 1341:
Line 1342: @TypeConverterAttribute(String.class)
Line 1343: @DefaultValueAttribute("Auto")
Line 1344: ClientConsoleModeDefault(501),
why not 422
Line 1345:
Line 1346: @TypeConverterAttribute(String.class)
Line 1347: @DefaultValueAttribute("3.1")
Line 1348: GlusterSupportedFrom(502),
Line 1344: ClientConsoleModeDefault(501),
Line 1345:
Line 1346: @TypeConverterAttribute(String.class)
Line 1347: @DefaultValueAttribute("3.1")
Line 1348: GlusterSupportedFrom(502),
423
Line 1349:
Line 1350: @TypeConverterAttribute(String.class)
Line 1351: @DefaultValueAttribute("3.2")
Line 1352: GlusterRefreshHeavyWeightSupportedFrom(503),
Line 1348: GlusterSupportedFrom(502),
Line 1349:
Line 1350: @TypeConverterAttribute(String.class)
Line 1351: @DefaultValueAttribute("3.2")
Line 1352: GlusterRefreshHeavyWeightSupportedFrom(503),
424
Line 1353:
Line 1354: Invalid(65535);
Line 1355:
Line 1356: private int intValue;
--
To view, visit http://gerrit.ovirt.org/13491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58ddb9bdcfa99b7f12926e414dd40a4b311a2163
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
