Daniel Erez has posted comments on this change.
Change subject: webadmin: Added POSIX options in Storage general sub tab
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java
Line 117: super.OnEntityChanged();
Line 118:
Line 119: if (getEntity() != null)
Line 120: {
Line 121: final StorageDomain storageDomain = (StorageDomain)
getEntity();
No need for 'final' keyword
Line 122:
Line 123: setIsNfs(storageDomain.getStorageType() ==
StorageType.NFS);
Line 124: setIsLocalS(storageDomain.getStorageType() ==
StorageType.LOCALFS);
Line 125: setIsPosix(storageDomain.getStorageType() ==
StorageType.POSIXFS);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 1258
Line 1259
Line 1260
Line 1261
Line 1262
Why replacing these with "Path"?
--
To view, visit http://gerrit.ovirt.org/13520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54d7d96709c8f5d7bc66b915e20b16cdb3ceaca9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
