Maor Lipchuk has uploaded a new change for review. Change subject: core: Remove not used PollVdsCommand. ......................................................................
core: Remove not used PollVdsCommand. Removed PollVdsCommand, there is no use of it in the engine code. Change-Id: Ie2f3bb2b71c3d4109d01cc495f401e5a745d31e3 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 3 files changed, 0 insertions(+), 31 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/13533/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java index a180d11..56c9d7c 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java @@ -189,8 +189,6 @@ StatusOnlyReturnForXmlRpc vmUpdateDevice(String vmId, XmlRpcStruct device); - FutureTask<Map<String, Object>> poll(); - StatusOnlyReturnForXmlRpc snapshot(String vmId, Map<String, String>[] snapParams); // Gluster vdsm Commands diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java deleted file mode 100644 index a7197d7..0000000 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java +++ /dev/null @@ -1,24 +0,0 @@ -package org.ovirt.engine.core.vdsbroker.vdsbroker; - -import org.ovirt.engine.core.common.vdscommands.VdsIdVDSCommandParametersBase; -import org.ovirt.engine.core.utils.log.Logged; -import org.ovirt.engine.core.utils.log.Logged.LogLevel; - -/** - * Sole purpose of this command is to check connectivity with VDSM by invoking getCapabilities verb. Generally it is - * used on network provisioning flows where VDSM is committing network changes only when traffic is from backend is - * detected (configurable behavior) - */ -@Logged(executionLevel = LogLevel.TRACE, errorLevel = LogLevel.DEBUG) -public class PollVDSCommand<P extends VdsIdVDSCommandParametersBase> extends FutureVDSCommand<P> { - - public PollVDSCommand(P parameters) { - super(parameters); - } - - @Override - protected void ExecuteVdsBrokerCommand() { - httpTask = getBroker().poll(); - } - -} diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java index c5970c2..d91d14f 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java @@ -946,11 +946,6 @@ } @Override - public FutureTask<Map<String,Object>> poll() { - return vdsServer.futurePing(); - } - - @Override public StatusOnlyReturnForXmlRpc snapshot(String vmId, Map<String, String>[] snapParams) { try { Map<String, Object> xmlRpcReturnValue = vdsServer.snapshot(vmId, snapParams); -- To view, visit http://gerrit.ovirt.org/13533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2f3bb2b71c3d4109d01cc495f401e5a745d31e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
