Vered Volansky has posted comments on this change. Change subject: core[WIP]: Remove not used ExtendVolume. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) What about ExtendVolumeVDSCommandParameters? Regarding vdsm side being re-examined - to see what should be removed there or could that mean not removing it here too? Should bdsm side be altered - who's responsibility is that once this patch is merged? This should be addressed, even if only in commit message. .................................................... Commit Message Line 5: CommitDate: 2013-04-02 20:49:54 +0300 Line 6: Line 7: core[WIP]: Remove not used ExtendVolume. Line 8: Line 9: Removed ExtendVolumneVDSCommand, there is no use of it in the engine s/ExtendVolumneVDSCommand/ExtendVolumeVDSCommand (extra n in volume) Line 10: code. Line 11: VDSM side should be re-examined Line 12: Line 13: Change-Id: I7d9eb342e4ab09c87bc30544cc0820b50cc0c692 -- To view, visit http://gerrit.ovirt.org/13534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d9eb342e4ab09c87bc30544cc0820b50cc0c692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
