Kanagaraj M has uploaded a new change for review. Change subject: webadmin: null checks added for Volume general model properties ......................................................................
webadmin: null checks added for Volume general model properties null checks are added for the volume general model properties to avoid NPE. Change-Id: Icaa6463054d6eefd589f5991c43b09b7d9247507 Signed-off-by: Kanagaraj M <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/13551/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java index 4d2512e..8dbb21e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java @@ -101,11 +101,11 @@ } GlusterVolumeEntity entity = (GlusterVolumeEntity) getEntity(); setName(entity.getName()); - setVolumeId(entity.getId().toString()); - setVolumeType(entity.getVolumeType().toString()); - setReplicaCount(Integer.toString(entity.getReplicaCount())); - setStripeCount(Integer.toString(entity.getStripeCount())); - setNumOfBricks(Integer.toString(entity.getBricks().size())); + setVolumeId(entity.getId() != null ? entity.getId().toString() : null); + setVolumeType(entity.getVolumeType() != null ? entity.getVolumeType().toString() : null); + setReplicaCount(entity.getReplicaCount() != null ? Integer.toString(entity.getReplicaCount()) : null); + setStripeCount(entity.getStripeCount() != null ? Integer.toString(entity.getStripeCount()) : null); + setNumOfBricks(entity.getBricks() != null ? Integer.toString(entity.getBricks().size()) : null); } } -- To view, visit http://gerrit.ovirt.org/13551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icaa6463054d6eefd589f5991c43b09b7d9247507 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
