Allon Mureinik has uploaded a new change for review. Change subject: core: Remove CanUpdateFieldGeneric ......................................................................
core: Remove CanUpdateFieldGeneric CanUpdateFieldGenericQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The CanUpdateFieldGenericQuery class 2. The CanUpdateFieldGeneric constant representing it in VdcQueryType 3. The CanUpdateFieldGenericParameters class which was only used by the removed query class. Change-Id: I644d8b5c6854de5c14b3a93fd37c2e77666a890e Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 52 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/13598/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java deleted file mode 100644 index f08822e..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java +++ /dev/null @@ -1,17 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.CanUpdateFieldGenericParameters; -import org.ovirt.engine.core.utils.ObjectIdentityChecker; - -public class CanUpdateFieldGenericQuery<P extends CanUpdateFieldGenericParameters> extends QueriesCommandBase<P> { - public CanUpdateFieldGenericQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue( - ObjectIdentityChecker.CanUpdateField(getParameters().getFieldContainer(), - getParameters().getFieldName(), getParameters().getStatus())); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java deleted file mode 100644 index 3abe001..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java +++ /dev/null @@ -1,32 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public class CanUpdateFieldGenericParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = -4028592911318806041L; - - public CanUpdateFieldGenericParameters(Object fieldContainer, String fieldName, Enum<?> status) { - _fieldName = fieldName; - _fieldContainer = fieldContainer; - _status = status; - } - - private Object _fieldContainer; - - public Object getFieldContainer() { - return _fieldContainer; - } - - private Enum<?> _status; - - public Enum<?> getStatus() { - return _status; - } - - private String _fieldName; - - public String getFieldName() { - return _fieldName; - } - - public CanUpdateFieldGenericParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 874ceb8..bffd3d1 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -124,9 +124,6 @@ // Bookmarks GetAllBookmarks, - // FieldsUpdating - CanUpdateFieldGeneric, - // Configuration values GetConfigurationValue(VdcQueryAuthType.User), GetConfigurationValues(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/13598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I644d8b5c6854de5c14b3a93fd37c2e77666a890e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
