Tal Nisan has uploaded a new change for review. Change subject: webadmin: Short comparison findbugs ......................................................................
webadmin: Short comparison findbugs Fixed findbugs warnings in StorageGeneralModel.java:129 and StorageGeneralModel.java:142 Change-Id: I8d06ece4dbaddb4ecd5372eae19bf729278e7572 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/13613/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java index 13d04c7..34bf696 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java @@ -126,7 +126,7 @@ } public void setTimeout(Short timeout) { - if (this.timeout != timeout) { + if (!isShortsEqual(this.timeout, timeout)) { this.timeout = timeout; OnPropertyChanged(new PropertyChangedEventArgs("Timeout")); //$NON-NLS-1$ } @@ -139,7 +139,7 @@ } public void setRetransmissions(Short retransmissions) { - if (this.retransmissions != retransmissions) { + if (!isShortsEqual(this.retransmissions, retransmissions)) { this.retransmissions = retransmissions; OnPropertyChanged(new PropertyChangedEventArgs("Retransmissions")); //$NON-NLS-1$ } @@ -198,4 +198,11 @@ } } + + private boolean isShortsEqual(Short a, Short b) { + if (a == null) { + return b == null; + } + return a.equals(b); + } } -- To view, visit http://gerrit.ovirt.org/13613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d06ece4dbaddb4ecd5372eae19bf729278e7572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
