Allon Mureinik has posted comments on this change.

Change subject: core: Remove unused command VmPoolToAdGroupBaseCommand
......................................................................


Patch Set 5: I would prefer that you didn't submit this

You should also remove VmPoolToAdElementParameters.

Additionally, after removing this command, RemoveAdGroupCommand is the only 
command left extending the abstract UserCommandBase - perhaps it's worth while 
to remove this redundant level of abstraction.

--
To view, visit http://gerrit.ovirt.org/13508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b77995d8443e93ee8246606d4834c2a4e3031a4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to