Michael Kublin has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
Line 199: getCompensationContext().stateChanged();
Line 200: return null;
Line 201: }
Line 202: });
Line 203:
Agreed, but at any case please use CompensationContext.snapshotEntityStatus()
Line 204: if (getParameters().getInstallVds()) {
Line 205: runVdsCommand(VDSCommandType.SetVdsStatus,
Line 206: new SetVdsStatusVDSCommandParameters(getVdsId(),
VDSStatus.Installing));
Line 207: }
--
To view, visit http://gerrit.ovirt.org/13622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
