Daniel Erez has uploaded a new change for review. Change subject: core: missing call to ProceedProxyReturnValue ......................................................................
core: missing call to ProceedProxyReturnValue Added missing call to ProceedProxyReturnValue in VmReplicateDiskStartVDSCommand and VmReplicateDiskFinishVDSCommand. Change-Id: I4ed1b66173cd7a644fc1b412c4c28010f92f0fa8 Bug-Url: https://bugzilla.redhat.com/923194 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/13726/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java index d2bae12..04223ca 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java @@ -10,6 +10,8 @@ @Override protected void ExecuteVdsBrokerCommand() { - getBroker().diskReplicateFinish(getParameters().getVmId().toString(), getSrcDiskXmlRpc(), getDstDiskXmlRpc()); + status = getBroker().diskReplicateFinish( + getParameters().getVmId().toString(), getSrcDiskXmlRpc(), getDstDiskXmlRpc()); + ProceedProxyReturnValue(); } } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java index baec468..0dcc953 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java @@ -10,6 +10,8 @@ @Override protected void ExecuteVdsBrokerCommand() { - getBroker().diskReplicateStart(getParameters().getVmId().toString(), getSrcDiskXmlRpc(), getDstDiskXmlRpc()); + status = getBroker().diskReplicateStart( + getParameters().getVmId().toString(), getSrcDiskXmlRpc(), getDstDiskXmlRpc()); + ProceedProxyReturnValue(); } } -- To view, visit http://gerrit.ovirt.org/13726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ed1b66173cd7a644fc1b412c4c28010f92f0fa8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
