Arik Hadas has posted comments on this change. Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and RunVmCommandBase ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-04-09 13:30:10 +0300 Line 4: Commit: Michael Kublin <[email protected]> Line 5: CommitDate: 2013-04-09 17:34:04 +0300 Line 6: Line 7: engine: Fixing perfromance issue between VdsRunTimeInfo and RunVmCommandBase perfromance -> performance Line 8: Line 9: After introducing atomic update, no need for special lock inside of Line 10: RunVmCommandBase.decreasePendingVms() Line 11: In order to keep funcytionality for delay: SynchronousQueue will be used. Line 7: engine: Fixing perfromance issue between VdsRunTimeInfo and RunVmCommandBase Line 8: Line 9: After introducing atomic update, no need for special lock inside of Line 10: RunVmCommandBase.decreasePendingVms() Line 11: In order to keep funcytionality for delay: SynchronousQueue will be used. funcytionality -> functionality Line 12: The thread will stuck untill time out or some other thread will add some object to queue Line 13: Line 14: Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Line 8: Line 9: After introducing atomic update, no need for special lock inside of Line 10: RunVmCommandBase.decreasePendingVms() Line 11: In order to keep funcytionality for delay: SynchronousQueue will be used. Line 12: The thread will stuck untill time out or some other thread will add some object to queue untill -> until Line 13: Line 14: Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 -- To view, visit http://gerrit.ovirt.org/13740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
