Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file ......................................................................
Patch Set 2: > The admin selected to run oVirt Engine, otherwise we won't be talking about > this, and oVirt Engine needs the modules, so the admin selected to load those > modules. The default of both supported distros (fedora, rhel) is ajp module enabled. So something had do be done manually and intentionally to disable it, no? > In my opinion it is much better to have the web server loudly and early fail > with an explicit error message than let it silently run with applications > that don't work. Can you please give an example of application that failing httpd load because of module is not loaded? > Downstream only packages are up to the downstream packagers, we can't count > on that. This is somewhat downstream only patch for centos and rhel... we can either help these downstream or patch software, I think that reorder is the cleanest solution. In better implementation we would have installed this file directly at the spec file, as there is no reason installer do this, since the ajp port can be fixed random. And then packager could have supported the naming. But for now, let's stick with installer behavior. > If you decide to change the name of the file then I would suggest to use a > name less tied to the name of the proxy configuration file in RHEL. I very much appreciate if every time you write that a variable/name can be improved, to provide a suggestion. I was thinking about zzz-ovirt-engine.conf :) > Also remember to modify the upgrade tool so that it performs the rename as > well. Sandro already done that. -- To view, visit http://gerrit.ovirt.org/13751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic37b672d262985b38ea253c165ae2234d70963d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
