Moti Asayag has posted comments on this change.

Change subject: core: Added Provider class
......................................................................


Patch Set 15: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java
Line 11:     private String name;
Line 12: 
Line 13:     private String description;
Line 14: 
Line 15:     private String url;
Btw. why not using a class which implements URL and add validators for it?
Line 16: 
Line 17:     public String getName() {
Line 18:         return name;
Line 19:     }


--
To view, visit http://gerrit.ovirt.org/10783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67e42286f513cf47dd057a6078ea365d6dff24e9
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to