Pradipta Banerjee has posted comments on this change.
Change subject: vdsm: vdsmid: do not attempt to install dmidecode on platforms
other than x86
......................................................................
Patch Set 1: Fails; I would prefer that you didn't submit this
(1 inline comment)
....................................................
File src/plugins/ovirt-host-deploy/vdsm/vdsmid.py
Line 75: condition=(
Line 76: lambda self: self.environment[odeploycons.VdsmEnv.VDSM_ID]
is None
Line 77: ),
Line 78: )
Line 79: def _packages(self):
Hi Alon,
arch is undefined here.
arch = platform.machine() ?
Line 80: if arch in ('x86_64', 'i686'):
Line 81: self.packager.install(('dmidecode',))
Line 82:
Line 83: @plugin.event(
--
To view, visit http://gerrit.ovirt.org/13744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
