Alona Kaplan has posted comments on this change. Change subject: webadmin: Gateway is not defined after bonding the RHEVM interface. ......................................................................
Patch Set 1: (2 inline comments) .................................................... Commit Message Line 10: and gateway- for managenemt network) are saved for the next attach. Line 11: Line 12: The bug was that in case of managemnet network the gateway parameter was Line 13: always determined from the nicEntity. Line 14: But if the management network if over vlan it should be taken from the Done Line 15: vlanNic. Line 16: Line 17: Change-Id: I7deff4305d04a6cfc943bb38cb795373ea7ff6e4 Line 18: Bug-Url: https://bugzilla.redhat.com/923443 .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java Line 133: netParams.setSubnet(vlanNic.getEntity().getSubnet()); Line 134: } Line 135: Line 136: if (isManagement()) { Line 137: if (!hasVlan()) { Done Line 138: netParams.setGateway(nicEntity.getGateway()); Line 139: } else { Line 140: netParams.setGateway(vlanNic.getEntity().getGateway()); Line 141: } -- To view, visit http://gerrit.ovirt.org/13790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7deff4305d04a6cfc943bb38cb795373ea7ff6e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
