Allon Mureinik has posted comments on this change. Change subject: db: add missing vdc_option for 3.3 ......................................................................
Patch Set 1: Looks good to me, but someone else must approve Re the storage 2.2 value - looks fine, please remove it as this patch suggests. Additionally, please note that the values UserDefinedVMProperties and VM64BitMaxMemorySizeInMB have the same value for 3.0,3.1,3.2 and 3.3 - perhaps they should be moved to have a single value with "general". However, I'm not sure this is in the scope of this patch. -- To view, visit http://gerrit.ovirt.org/13748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12406fd340b778cb2160ec063d68c4f3c5a42518 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
