Gilad Chaplik has posted comments on this change.
Change subject: engine: VmTemplate cleanup (3/3)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
Line 95: diskTemplateMap = new HashMap<Guid, DiskImage>();
Line 96:
Line 97: this.childCount = childCount;
Line 98: setName(name);
Line 99: this.setNumOfMonitors(numMonitors);
* shouldn't 'setNumOfMonitors' change as well?
* for a complete clean-up consider removing unnecessary 'this.' ref to setters.
Line 100: this.setStatus(VmTemplateStatus.forValue(status));
Line 101: }
Line 102:
Line 103: public int getChildCount() {
--
To view, visit http://gerrit.ovirt.org/13769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f4a5e155eaa2c81f823a4abe249086a74e5eb18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
