Yair Zaslavsky has posted comments on this change.
Change subject: core: introducing scheduling framework
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/taskmgr/src/main/java/org/ovirt/engine/core/taskmgr/scheduler/SimpleOperationScheduler.java
Line 73: }
Line 74: }
Line 75:
Line 76: closestExpirationSec = Integer.MAX_VALUE;
Line 77:
One of the problems we discussed about invokeAll, invokeAny and invoke are the
limitation on by the generic type of the Generic (see definition of invokeAll).
One way to solve it is of course pass some interface (or event Object) to
invokeAll (this is just an example), but I don't think I like this idea.
Line 78: synchronized (_tasks) {
Line 79: for (int i = 0; i < _tasks.size(); i++) {
Line 80: final OperationEntry<?> task = _tasks.get(i);
Line 81: if (task.isExpired() || task.isDone()) {
--
To view, visit http://gerrit.ovirt.org/13795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07253e8465776482bbdade21d78e9b40eeaadbb5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
