Alona Kaplan has posted comments on this change. Change subject: webadmin: Created class hierarchy for bond popups ......................................................................
Patch Set 1: Looks good to me, approved (2 inline comments) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java Line 21: Line 22: // hide widgets Line 23: info.setVisible(false); Line 24: message.setVisible(false); Line 25: checkConnectivity.setVisible(false); Redundant, you already did getCheckConnectivity().setIsAvailable(false) in SetupNetworksBondPopupView Line 26: commitChanges.setVisible(false); Line 27: // resize Line 28: layoutPanel.remove(infoPanel); Line 29: layoutPanel.setWidgetSize(mainPanel, 300); Line 22: // hide widgets Line 23: info.setVisible(false); Line 24: message.setVisible(false); Line 25: checkConnectivity.setVisible(false); Line 26: commitChanges.setVisible(false); Should be done on the model side (same as checkConnectivity). Line 27: // resize Line 28: layoutPanel.remove(infoPanel); Line 29: layoutPanel.setWidgetSize(mainPanel, 300); Line 30: asPopupPanel().setPixelSize(400, 400); -- To view, visit http://gerrit.ovirt.org/13678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4de41a5d298bf922e9ad7fee64ee2b62c3700 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
