Maor Lipchuk has posted comments on this change.

Change subject: engine: watchdog - logic changes [wip]
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 500:                 if (getVm().isSmartcardEnabled() != 
getVmTemplate().isSmartcardEnabled())
Line 501:                 {
Line 502:                     
VmDeviceUtils.updateSmartcardDevice(getVm().getId(), 
getVm().isSmartcardEnabled());
Line 503:                 }
Line 504: 
I think this is not related to the change.
Line 505:                 setActionReturnValue(getVm().getId());
Line 506:                 setSucceeded(true);
Line 507:             }
Line 508:         } else {


--
To view, visit http://gerrit.ovirt.org/13058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8959f7fe37a1ef4a8ec82ee749a47311553cef18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to