Michael Kublin has posted comments on this change.

Change subject: core: wip: initVdsOnUp - reconstructs and host status.
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 136:             returnValue = true;
Line 137:             _connectStorageSucceeded = true;
Line 138:             _connectPoolSucceeded = true;
Line 139:         } else {
Line 140:             HostStoragePoolParametersBase params = new 
HostStoragePoolParametersBase(getStoragePool(), getVds());
please remove here condition and appropriate code for checking storage 
connections inside ConnectHostToStoragePoolServers
Line 141:             if (Backend.getInstance()
Line 142:                     
.runInternalAction(VdcActionType.ConnectHostToStoragePoolServers, params)
Line 143:                     .getSucceeded()) {
Line 144:                 _connectStorageSucceeded = true;


--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6418b9d2826146e1e4ceff4341c6d7cd3a0024af
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to