Alona Kaplan has posted comments on this change.
Change subject: webadmin: Extended capabilities of bond operations
......................................................................
Patch Set 1: (2 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-04-10 10:57:40 +0300
Line 6:
Line 7: webadmin: Extended capabilities of bond operations
Line 8:
Line 9: The BOND_WITH operation used to only received regular NICs as arguments,
As I understand the requirements of the bug- Bond A dragged on to Bond B =>
New bond dialog with Bond B properties filled in but allows to select Bond A
properties*.
In your patch both bonds A and B are broken and a new bond is created.
Please update the bug or your functionality:)
Line 10: but from now on will be able to handle bond arguments as well. When
Line 11: dealing with them, NICs are "collected" and put into the new bond, and
Line 12: any bond passed as argument is broken.
Line 13:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
Line 149: assert op2 instanceof NetworkInterfaceModel;
Line 150: assert params.length == 1 : "incorrect params
length"; //$NON-NLS-1$
Line 151:
Line 152: Set<NetworkInterfaceModel> nics = new
HashSet<NetworkInterfaceModel>();
Line 153: if (op1 instanceof BondNetworkInterfaceModel) {
you can extract this code to a method and reuse it in the next block.
Line 154: nics.addAll(((BondNetworkInterfaceModel)
op1).getBonded());
Line 155: NetworkOperation.BREAK_BOND.getCommand(op1,
null, allNics).Execute();
Line 156: } else {
Line 157: nics.add((NetworkInterfaceModel) op1);
--
To view, visit http://gerrit.ovirt.org/13773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bcd6e55f0cf852581541462a7fe0e8d7c44fec7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
