Laszlo Hornyak has posted comments on this change.
Change subject: core: VdsDAO.getAllWithName now returns instance
......................................................................
Patch Set 1: (2 inline comments)
other than the method name, I agree with the patch
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
Line 41: .addValue("is_filtered", isFiltered));
Line 42: }
Line 43:
Line 44: @Override
Line 45: public VDS get(String name) {
getByName would be probably better, there would be way too many get() methods
in this dao. see below.
Line 46: return getCallsHandler().executeRead("GetVdsByName",
Line 47: VdsRowMapper.instance,
Line 48: getCustomMapSqlParameterSource()
Line 49: .addValue("vds_name", name));
Line 49: .addValue("vds_name", name));
Line 50: }
Line 51:
Line 52: @Override
Line 53: public List<VDS> getAllForHostname(String hostname) {
hostname is unique as well (just for example)
Line 54: return getCallsHandler().executeReadList("GetVdsByHostName",
Line 55: VdsRowMapper.instance,
Line 56: getCustomMapSqlParameterSource()
Line 57: .addValue("host_name", hostname));
--
To view, visit http://gerrit.ovirt.org/13827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a0cb37c98f1a4373028e6210e45261cd432eed3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
