Allon Mureinik has uploaded a new change for review. Change subject: core: Removed searchbackend tests stdout printing ......................................................................
core: Removed searchbackend tests stdout printing Stopped printing (using System.out.println) in searchbackend tests since the information printed out is useless (and even if it wasn't, logging should have been used instead). Change-Id: I749c91fcc6c5f3558b9af6a426a251fc20eb279d Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 4 files changed, 1 insertion(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/13862/1 diff --git a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java index 61d68bb..9cdba96 100644 --- a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java +++ b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java @@ -20,7 +20,6 @@ public void testEmpty() { IConditionFieldAutoCompleter comp = new AdGroupConditionFieldAutoCompleter(); List<String> comps = Arrays.asList(comp.getCompletion("")); - System.out.println(comps); assertTrue("name", comps.contains("name")); assertFalse("False", comps.contains("False")); } diff --git a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java index 6155a77..d39ae70 100644 --- a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java +++ b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java @@ -14,7 +14,6 @@ public void testValues() { DateEnumValueAutoCompleter comp = new DateEnumValueAutoCompleter(Jedi.class); List<String> comps = Arrays.asList(comp.getCompletion(" ")); - System.out.println(comps); assertTrue("Monday", comps.contains("Monday") || comps.contains("Tuesday")); assertTrue("mace", comps.contains("mace")); } diff --git a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java index 5efc391..fc7f7f1 100644 --- a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java +++ b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java @@ -14,7 +14,6 @@ public void testValues() { IAutoCompleter comp = new EnumValueAutoCompleter(Jedi.class); List<String> comps = Arrays.asList(comp.getCompletion("L")); - System.out.println(comps); assertTrue("luke", comps.contains("luke")); assertTrue("leia", comps.contains("leia")); } diff --git a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java index 0ebcb60..2979c60 100644 --- a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java +++ b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java @@ -14,20 +14,8 @@ @Rule public MockConfigRule mcr = new MockConfigRule(); - public void dumpCompletionArray(SyntaxContainer res) { - System.out.print("["); - for (String item : res.getCompletionArray()) { - System.out.print(" " + item); - } - System.out.print("]"); - } - public boolean contains(SyntaxContainer res, String item) { - boolean returnValue = Arrays.asList(res.getCompletionArray()).contains(item); - if (!returnValue) { - this.dumpCompletionArray(res); - } - return returnValue; + return Arrays.asList(res.getCompletionArray()).contains(item); } /** @@ -57,7 +45,6 @@ SyntaxChecker chkr = new SyntaxChecker(20, true); SyntaxContainer res = null; res = chkr.getCompletion(""); - this.dumpCompletionArray(res); assertTrue("Hosts", contains(res, "Hosts")); res = chkr.getCompletion("H"); assertTrue("Hots2", contains(res, "Hosts")); -- To view, visit http://gerrit.ovirt.org/13862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I749c91fcc6c5f3558b9af6a426a251fc20eb279d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
