Allon Mureinik has posted comments on this change.
Change subject: core: add the paramSource keys to the name parameters
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I don't get this patch.
paramSource is handled in executeImpl, for all the calls.
what am I missing?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 33: SimpleJdbcCall createCall();
Line 34: }
Line 35:
Line 36: public Map<String, Object> executeModification(final String
procedureName, final MapSqlParameterSource paramSource) {
Line 37: return executeImpl(procedureName, paramSource,
createCallForModification(procedureName, paramSource));
you already have paramSource as the second argument
Line 38: }
Line 39:
Line 40: public int executeModificationReturnResult(final String
procedureName, final MapSqlParameterSource paramSource) {
Line 41: Integer procedureResult = null;
--
To view, visit http://gerrit.ovirt.org/13865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df6d12655ca46b248f85850081f6f8571302125
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
