Allon Mureinik has uploaded a new change for review. Change subject: core: Removed AddSelfPermissionCommand ......................................................................
core: Removed AddSelfPermissionCommand This command is unused, and it does not seem to have any meaningful content, and thus can be removed. This patch removes the following: 1. The MigrateIrsSnapshotsRoVdcCommand class 2. The corresponding constant in VdcActionType Change-Id: I479e62b29570b8e6c3b7fec811efd58b50a5dc86 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/13955/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java deleted file mode 100644 index 21955b8..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java +++ /dev/null @@ -1,23 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.action.PermissionsOperationsParametes; -import org.ovirt.engine.core.common.action.VdcActionType; -import org.ovirt.engine.core.compat.Guid; - -public class AddSelfPermissionCommand<T extends PermissionsOperationsParametes> extends AddPermissionCommand<T> { - private static final long serialVersionUID = 3521308383376252911L; - - public AddSelfPermissionCommand(T parameters) { - super(parameters); - } - - @Override - protected boolean canDoAction() { - boolean returnValue = true; - if (!(getParameters().getPermission().getrole_id().equals(new Guid("00000000-0000-0000-0001-000000000001")) || getParameters() - .getParentCommand() == VdcActionType.AddSelfPermission)) { - returnValue = false; - } - return returnValue; - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java index b0758c8..e884df1 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java @@ -174,7 +174,6 @@ AttachActionGroupsToRole(805, ActionGroup.MANIPULATE_ROLES, false, QuotaDependency.NONE), DetachActionGroupsFromRole(806, ActionGroup.MANIPULATE_ROLES, false, QuotaDependency.NONE), AddRoleWithActionGroups(809, ActionGroup.MANIPULATE_ROLES, false, QuotaDependency.NONE), - AddSelfPermission(810, QuotaDependency.NONE), AddSystemPermission(811, ActionGroup.MANIPULATE_PERMISSIONS, false, QuotaDependency.NONE), /** -- To view, visit http://gerrit.ovirt.org/13955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I479e62b29570b8e6c3b7fec811efd58b50a5dc86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
