Shireesh Anjal has posted comments on this change.
Change subject: engine: New test method in DBConfigUtilsTest
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java
Line 67: public void testGetValue() {
Line 68: // Verify that values for 3.0 and 3.2 are from DB (since the
entries are present in fixtures.xml)
Line 69: // and for 3.1, it's the default value from annotation in
ConfigValues.
Line 70: // 3.0 -> false, 3.1 -> true, 3.2 -> true
Line 71:
Assert.assertFalse((Boolean)config.GetValue(ConfigValues.NonVmNetworkSupported,
"3.0"));
Actually, now I remember why I did this! The first one is a call on "config",
which is an instance of DBConfigUtils, which doesn't provide the generics
mechanism to expect a Boolean. And the second call is on the static method in
class Config. I think I should add it back, but will wait for your response
before I do that.
Line 72: Assert.assertFalse(Config.<Boolean>
GetValue(ConfigValues.NonVmNetworkSupported, "3.0"));
Line 73:
Line 74:
Assert.assertTrue((Boolean)config.GetValue(ConfigValues.NonVmNetworkSupported,
"3.1"));
Line 75: Assert.assertTrue(Config.<Boolean>
GetValue(ConfigValues.NonVmNetworkSupported, "3.1"));
--
To view, visit http://gerrit.ovirt.org/13787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia736419e766bc6ce2e82158f775817e885b90dfd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
