Alon Bar-Lev has posted comments on this change.

Change subject: packaging: refactored firewalld support
......................................................................


Patch Set 4:

I am so sorry I am picky... but... unless there is a good reason, please try to 
do the best to sync the structure of the files installed and the structure of 
files within the source tree.

In this case the rules/templates can be organized with the prefix directory so 
that the structure will be similar.

 packaging/resources/firewalld/{base,aio}/...

Sure, we will need to fix this in future and reorganize other files left after 
the otopi introduction, so we can copy as-is the aux tree in Makefile...

--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6a60e1667182f926f399e22bbfbb939e7171cb0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to