Alon Bar-Lev has posted comments on this change.
Change subject: gluster: starting glusterd after install
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File src/plugins/ovirt-host-deploy/gluster/packages.py
Line 77: self.packager.installUpdate(('vdsm-gluster',))
Line 78:
Line 79: @plugin.event(
Line 80: stage=plugin.Stages.STAGE_CLOSEUP,
Line 81: priority=plugin.Stages.PRIORITY_LOW
Any reason why priority is added?
You need to add: condition=lambda self: self._enabled,
Line 82: )
Line 83: def _start(self):
Line 84: self.logger.info(_('Starting gluster'))
Line 85: self.services.state('glusterd', True)
Line 79: @plugin.event(
Line 80: stage=plugin.Stages.STAGE_CLOSEUP,
Line 81: priority=plugin.Stages.PRIORITY_LOW
Line 82: )
Line 83: def _start(self):
Please call it _closeup
Line 84: self.logger.info(_('Starting gluster'))
Line 85: self.services.state('glusterd', True)
Line 86:
Line 81: priority=plugin.Stages.PRIORITY_LOW
Line 82: )
Line 83: def _start(self):
Line 84: self.logger.info(_('Starting gluster'))
Line 85: self.services.state('glusterd', True)
Is this package installed in vdsm-gluster? if not, this does not belong here...
Line 86:
--
To view, visit http://gerrit.ovirt.org/14030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f65ea6cbb54c844fb42ad1a14c61c438ac0865a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
