Vojtech Szocs has posted comments on this change.

Change subject: webadmin: User Event Notification dialog element IDs
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File frontend/webadmin/modules/pom.xml
Line 43:     
<aspectj.agent>-javaagent:${settings.localRepository}/org/aspectj/aspectjweaver/${aspectj.version}/aspectjweaver-${aspectj.version}.jar</aspectj.agent>
Line 44:     <!-- Regular expression that matches types that GWT compiler 
shouldn't prune (avoid dead code optimization) -->
Line 45:     
<gwt.dontPrune>-Dgwt.dontPrune=org\.ovirt\.engine\.core\.(common|compat)\..*</gwt.dontPrune>
Line 46:     <!-- This can be overridden by setting this property in your 
personal settings.xml -->
Line 47:     <gwt-plugin.extraJvmArgs>-Xss32M -Xms1024M -Xmx2048M 
-XX:PermSize=256M -XX:MaxPermSize=512M</gwt-plugin.extraJvmArgs>
Sorry, this shouldn't be here, will remove this in new patch set.
Line 48:     <!-- Control target browsers for GWT compilation, maps to 
'user.agent' deferred binding property in *.gwt.xml -->
Line 49:     <!-- By default, all modern browsers are supported, see 
[gwt-user.jar:com/google/gwt/user/UserAgent.gwt.xml] for a complete list -->
Line 50:     <gwt.userAgent>ie8,ie9,gecko1_8,safari,opera</gwt.userAgent>
Line 51:     <!-- Control target locales for GWT compilation, maps to 'locale' 
deferred binding property in *.gwt.xml -->


--
To view, visit http://gerrit.ovirt.org/14048
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to