Sandro Bonazzola has posted comments on this change.
Change subject: Package must own all directories that it creates.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File ovirt-image-uploader.spec.in
Line 52: %doc AUTHORS
Line 53: %doc COPYING
Line 54: %config(noreplace) %{_sysconfdir}/ovirt-engine/imageuploader.conf
Line 55: %{_sysconfdir}/ovirt-engine/imageuploader.conf.d/.keep
Line 56: %{python_sitelib}/ovirt_image_uploader/*.py*
this ^^^ lead to warning: File listed twice:
/usr/lib/python2.7/site-packages/ovirt_image_uploader/*.py*
Line 57: %{python_sitelib}/ovirt_image_uploader
Line 58: %{python_sitelib}/ovirt_image_uploader/ovf/*.py*
Line 59: %{_bindir}/engine-image-uploader
Line 60: %{_mandir}/man8/*
Line 53: %doc COPYING
Line 54: %config(noreplace) %{_sysconfdir}/ovirt-engine/imageuploader.conf
Line 55: %{_sysconfdir}/ovirt-engine/imageuploader.conf.d/.keep
Line 56: %{python_sitelib}/ovirt_image_uploader/*.py*
Line 57: %{python_sitelib}/ovirt_image_uploader
Alon, kiril has not used %dir here, the above line will include in the rpm
everything under %{python_sitelib}/ovirt_image_uploader, including
%{python_sitelib}/ovirt_image_uploader/ovf
Line 58: %{python_sitelib}/ovirt_image_uploader/ovf/*.py*
Line 59: %{_bindir}/engine-image-uploader
Line 60: %{_mandir}/man8/*
Line 61:
Line 54: %config(noreplace) %{_sysconfdir}/ovirt-engine/imageuploader.conf
Line 55: %{_sysconfdir}/ovirt-engine/imageuploader.conf.d/.keep
Line 56: %{python_sitelib}/ovirt_image_uploader/*.py*
Line 57: %{python_sitelib}/ovirt_image_uploader
Line 58: %{python_sitelib}/ovirt_image_uploader/ovf/*.py*
this ^^^ lead to warning: File listed twice:
/usr/lib/python2.7/site-packages/ovirt_image_uploader/ovf/*.py*
Line 59: %{_bindir}/engine-image-uploader
Line 60: %{_mandir}/man8/*
Line 61:
Line 62: %changelog
--
To view, visit http://gerrit.ovirt.org/14040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df07d9d7f39014447ba42b15d90d652c61781aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
