Alon Bar-Lev has posted comments on this change.

Change subject: Remove sh bang from ovfenvelope.py.
......................................................................


Patch Set 2: No score

> for manual testing you can always use 'python ovfenvelope.py' or 'python -m 
> ovfenvelope' and it will run. No need for sh-bang line.

Right. Question is... why does anyone cares if there is or there is no 
sh-bang?!?! It makes it easier to run individual modules, have simple units and 
usages. Its true that no sh-bang should be specified if module is not meant to 
be run at all... but...

I leave this to you...

--
To view, visit http://gerrit.ovirt.org/14043
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43d530cf1f826834672fd7cc4cb93ab4601d8865
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to