Daniel Erez has posted comments on this change.
Change subject: frontend: reduce duplicate code related to run-once capability
- cont
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
Line 452: public RunOnceModel(VM vm, ArrayList<String>
customPropertiesKeysList, ICommandTarget commandTarget)
Line 453: {
Line 454: this.vm = vm;
Line 455: this.customPropertiesKeysList = customPropertiesKeysList;
Line 456: this.commandTarget = commandTarget;
I still don't like the fact that the model holds the ListModel which created it.
Consider adding an event instead, if not too difficult (could be done later on
a separate patch).
Line 457:
Line 458: setAttachFloppy(new EntityModel());
Line 459: getAttachFloppy().getEntityChangedEvent().addListener(this);
Line 460: setFloppyImage(new ListModel());
Line 909: }
Line 910: }
Line 911: else if (command == cancelCommand)
Line 912: {
Line 913: commandTarget.ExecuteCommand(command);
We still need to add an event driven mechanism instead of just passing the
entire ListModel (commandTarget) - but that's probably for a separate patch...
Line 914: }
Line 915: }
Line 916: protected abstract void onRunOnce();
--
To view, visit http://gerrit.ovirt.org/13904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I774524ca7bd4af35d8c3140e2ce23f369d727e28
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
