Arik Hadas has posted comments on this change. Change subject: frontend: fluent API instead of temporary fields ......................................................................
Patch Set 9: (2 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java Line 65 Line 66 Line 67 Line 68 Line 69 At first I changed the 'setEntity' method to return 'this' also, so I found those places where it was overridden because I had to change them as well. now, it's not critical to include it in this patch but since it is really minor and safe to remove them I think it can be part of this patch .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java Line 725 Line 726 Line 727 Line 728 Line 729 it was needed before because we used the selected item to get the VM instance which we'll run, but currently we don't need it - we use the VM that was used to initialize the RunOnceModel on #RunOnce(). if you select a VM and open the run-once dialog, when you press OK, it doesn't matter which VM is now selected, you should perform on the once that was selected when the run-once dialog was shown.. -- To view, visit http://gerrit.ovirt.org/13246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bfe6b084ecc0643a5a45a1fb9a1170b415ed15 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
