Daniel Erez has posted comments on this change. Change subject: core: Remove checkImagesLocked(vmId, messages) ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 8: Line 9: Removed ImagesHandler.checkImagesLocked(Guid vmId, List<String Line 10: messages), as ImagesHandler should not know about VMs. Line 11: Line 12: Wherever in was used (two places - AddVmFromSnapshot and s/in/it Line 13: LiveMigrateVmDisks), it was replaced with a direct call to DiskDao and Line 14: then a simpler call to Line 15: ImagesHandler.checkImagesLocked (messages, disks). Line 16: -- To view, visit http://gerrit.ovirt.org/14100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
