Alon Bar-Lev has posted comments on this change. Change subject: packaging: default rpm packaging to build complete feature set ......................................................................
Patch Set 1: > There are no build_minimal or build_quick generic macros. Currently... can you guarantee that in future also? can you guarantee that user will not have a package with similar settings and he has these in /etc/rpm/macros.* or at ~/.rpmmacros? Having a name space (prefix) for local macros is good, apart of avoiding conflicts, it makes it clear that these are local macros for this package. -- To view, visit http://gerrit.ovirt.org/14083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb610db6c6b6f9b209c816609613e47d7520baf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
