Alon Bar-Lev has posted comments on this change.
Change subject: Fix --version option
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File src/config.py.in.in
Line 3: """
Line 4:
Line 5: PACKAGE_NAME = "@PACKAGE_NAME@"
Line 6: PACKAGE_RPM_VERSION = "@PACKAGE_RPM_VERSION@"
Line 7: PACKAGE_RPM_RELEASE = "@PACKAGE_RPM_RELEASE@"
No no no, you do not reference RPM within upstream.
The fact that we generate a specific *EXAMPLE* of sepc file with specific
release implies nothing.
You should manage it similar to the DISPLAY_VERSION of ovirt-engine.
Adding --with-display-version= to configure.ac, default is @PACKAGE_VERSION@,
in spec you provide --with-display-version=%{version}-%{release}.
While I don't like this approach at all, as --version should display the
version of the upstream project, so having here @PACKAGE_VERSION@ is enough.
If someone wishes to see the downstream version he should look into downstream
tools, such as rpm -q.
See examples:
ls --version
tar --version
gpg --version
Line 8:
Line 9: FILE_PG_PASS = "@engineconfigdir_POST@/.pgpass"
Line 10:
Line 11: DEFAULT_CA_PEM = "@sysconfdir_POST@/pki/ovirt-engine/ca.pem"
--
To view, visit http://gerrit.ovirt.org/14118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If817260837cadf6a64cf9a4d6a21af6776c48a6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
