Gilad Chaplik has posted comments on this change. Change subject: engine: filtering search based on Application Mode ......................................................................
Patch Set 4: (3 inline comments) .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AuditCrossRefAutoCompleter.java Line 18: mVerbs.put(SearchObjects.VDC_USER_PLU_OBJ_NAME, SearchObjects.VDC_USER_PLU_OBJ_NAME); Line 19: mVerbs.put(SearchObjects.VDC_CLUSTER_PLU_OBJ_NAME, SearchObjects.VDC_CLUSTER_PLU_OBJ_NAME); Line 20: Line 21: buildCompletions(); Line 22: mVerbs.put(SearchObjects.VM_OBJ_NAME, SearchObjects.VM_OBJ_NAME); you want to exclude virt also in validations? because in http://gerrit.ovirt.org/#/c/13704/4/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/UserCrossRefAutoCompleter.java you do. Line 23: mVerbs.put(SearchObjects.VDS_OBJ_NAME, SearchObjects.VDS_OBJ_NAME); Line 24: mVerbs.put(SearchObjects.TEMPLATE_OBJ_NAME, SearchObjects.TEMPLATE_OBJ_NAME); Line 25: mVerbs.put(SearchObjects.VDC_USER_OBJ_NAME, SearchObjects.VDC_USER_OBJ_NAME); Line 26: mVerbs.put(SearchObjects.VDC_CLUSTER_OBJ_NAME, SearchObjects.VDC_CLUSTER_OBJ_NAME); .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java Line 18: public static ISyntaxChecker CreateUISyntaxChecker(String AuthenticationMethod, ApplicationMode applicationMode) { Line 19: ConfigAuthenticationMethod = AuthenticationMethod; Line 20: APPLICATION_MODE = applicationMode; Line 21: if (uiSyntaxChecker == null) { Line 22: uiSyntaxChecker = new SyntaxChecker(100, true); 100 is funny :) Line 23: } Line 24: return uiSyntaxChecker; Line 25: } Line 26: Line 23: } Line 24: return uiSyntaxChecker; Line 25: } Line 26: Line 27: public static ISyntaxChecker CreateBackendSyntaxChecker(String AuthenticationMethod) { you don't want to filter REST search? Line 28: ConfigAuthenticationMethod = AuthenticationMethod; Line 29: if(backendSyntaxChecker == null) { Line 30: backendSyntaxChecker = new SyntaxChecker(Config.<Integer> GetValue(ConfigValues.SearchResultsLimit), Line 31: true); -- To view, visit http://gerrit.ovirt.org/13704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2e9293bb26616a170a3edcc2184cce748cbc9c0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Libor Spevak <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
