Lior Vernia has posted comments on this change.
Change subject: webadmin: Rewrote Setup Networks operation logic
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
Line 130: return
NetworkOperation.NULL_OPERATION_TOO_MANY_NON_VLANS;
Line 131: } else if (vmNetwork != null && vlanFound) {
Line 132: if (op1 instanceof NetworkInterfaceModel) {
Line 133: dst.setCulpritNetwork(vmNetwork);
Line 134: }
Ended up splitting these null operations in two - one for adding networks, one
for bonding - like the others. Made more sense with respect to error messages.
Line 135: return
NetworkOperation.NULL_OPERATION_VM_WITH_VLANS;
Line 136: }
Line 137: }
Line 138:
--
To view, visit http://gerrit.ovirt.org/13775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5793221d295fa0bd73fc1ed988c90df8fee7c8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
