Hello Ravi Nori,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14162
to review the following change.
Change subject: cli: Error in "update network --cluster-identifier
--usages-usage"
......................................................................
cli: Error in "update network --cluster-identifier --usages-usage"
When running update network command, in cluster context,
including --usages-usage option causes an error.
Change-Id: I9a3347c4cd7397f0e58814c33bbf4b18e07547f2
Bug-Url: https://bugzilla.redhat.com/950993
Signed-off-by: Ravi Nori <[email protected]>
---
M src/ovirtcli/command/command.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/62/14162/1
diff --git a/src/ovirtcli/command/command.py b/src/ovirtcli/command/command.py
index b6209aa..fe53671 100644
--- a/src/ovirtcli/command/command.py
+++ b/src/ovirtcli/command/command.py
@@ -95,6 +95,10 @@
except:
return param
+ def __do_set_primitive_list_data(self, obj, prop, val):
+ for param in str(val).split(','):
+ getattr(obj, prop).append(param)
+
def __do_set_data(self, obj, prop, fq_prop, val):
"""INTERNAL: set data in to object based on 'prop' map segmentation"""
if prop.find('-') != -1:
@@ -112,7 +116,8 @@
obj_params_set_cand = params_set_cand.factory()
root_obj_params_set_cand = obj_params_set_cand
else:
- self.error(Messages.Error.NO_SUCH_TYPE % props[i])
+ self.__do_set_primitive_list_data(obj, props[i],
val)
+ return
if not val:
self.error(Messages.Error.INVALID_COLLECTION_BASED_OPTION_SYNTAX % prop)
--
To view, visit http://gerrit.ovirt.org/14162
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a3347c4cd7397f0e58814c33bbf4b18e07547f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
