Tal Nisan has uploaded a new change for review. Change subject: frontend: Fix findbugs method doesn't start with lower case ......................................................................
frontend: Fix findbugs method doesn't start with lower case Fix findbugs method doesn't start with a lower case letter error in frontend ListModel class methods ItemsChanging, ItemsChanged, UnsubscribeList, SubscribeList, ItemsCollectionChanged, ValidateSelectedItem and SelectedItemChangedEventDefinition property Change-Id: Iab6b62a4e9806805b3282ed653ac1e4aa74768e4 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 38 files changed, 105 insertions(+), 105 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/14183/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java index 1673b75..2fa4ae4 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java @@ -834,7 +834,7 @@ { BookmarkListModel_Navigated(sender, (BookmarkEventArgs) args); } - else if (ev.matchesDefinition(SelectedItemChangedEventDefinition) && sender == getSystemTree()) + else if (ev.matchesDefinition(selectedItemChangedEventDefinition) && sender == getSystemTree()) { SystemTree_ItemChanged(sender, args); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java index 415e5aa..8802c99 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java @@ -18,7 +18,7 @@ public class ListModel extends EntityModel { - public static EventDefinition SelectedItemChangedEventDefinition; + public static EventDefinition selectedItemChangedEventDefinition; private Event privateSelectedItemChangedEvent; public Event getSelectedItemChangedEvent() @@ -106,9 +106,9 @@ { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; - ItemsChanged(); + itemsChanged(); getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ } @@ -146,14 +146,14 @@ static { - SelectedItemChangedEventDefinition = new EventDefinition("SelectedItemChanged", ListModel.class); //$NON-NLS-1$ + selectedItemChangedEventDefinition = new EventDefinition("SelectedItemChanged", ListModel.class); //$NON-NLS-1$ SelectedItemsChangedEventDefinition = new EventDefinition("SelectedItemsChanged", ListModel.class); //$NON-NLS-1$ ItemsChangedEventDefinition = new EventDefinition("ItemsChanged", ListModel.class); //$NON-NLS-1$ } public ListModel() { - setSelectedItemChangedEvent(new Event(SelectedItemChangedEventDefinition)); + setSelectedItemChangedEvent(new Event(selectedItemChangedEventDefinition)); setSelectedItemsChangedEvent(new Event(SelectedItemsChangedEventDefinition)); setItemsChangedEvent(new Event(ItemsChangedEventDefinition)); } @@ -180,8 +180,8 @@ return; } - UnsubscribeList(oldValue); - SubscribeList(newValue); + unsubscribeList(oldValue); + subscribeList(newValue); } @Override @@ -225,7 +225,7 @@ } else if (ev.matchesDefinition(ProvideCollectionChangedEvent.Definition)) { - ItemsCollectionChanged(sender, (NotifyCollectionChangedEventArgs) args); + itemsCollectionChanged(sender, (NotifyCollectionChangedEventArgs) args); } } @@ -244,14 +244,14 @@ { } - protected void ItemsChanged() + protected void itemsChanged() { // if Items are updated, SelectedItem and SelectedItems become irrelevant: setSelectedItem(null); setSelectedItems(null); } - protected void ItemsChanging(Iterable newValue, Iterable oldValue) + protected void itemsChanging(Iterable newValue, Iterable oldValue) { IProvideCollectionChangedEvent notifier = (IProvideCollectionChangedEvent) ((oldValue instanceof IProvideCollectionChangedEvent) ? oldValue @@ -270,14 +270,14 @@ } // Unsure subscribing to the property change notification for all items. - UnsubscribeList(oldValue); - SubscribeList(newValue); + unsubscribeList(oldValue); + subscribeList(newValue); } /** * Invoked whenever items collection was changed, i.e. some items was added or removed. */ - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { if (!getNotifyPropertyChangeForAnyItem()) { @@ -285,11 +285,11 @@ } // Track property change on all items as necessary. - UnsubscribeList(e.OldItems); - SubscribeList(e.NewItems); + unsubscribeList(e.OldItems); + subscribeList(e.NewItems); } - public void ValidateSelectedItem(IValidation[] validations) + public void validateSelectedItem(IValidation[] validations) { setIsValid(true); @@ -314,7 +314,7 @@ } } - private void SubscribeList(Iterable list) + private void subscribeList(Iterable list) { if (list == null) { @@ -332,7 +332,7 @@ } } - private void UnsubscribeList(Iterable list) + private void unsubscribeList(Iterable list) { if (list == null) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java index 29a8066..7b15e52 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java @@ -316,7 +316,7 @@ { getUserName().validateEntity(new IValidation[] { new NotEmptyValidation() }); getPassword().validateEntity(new IValidation[] { new NotEmptyValidation() }); - getDomain().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getDomain().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); return getUserName().getIsValid() && getPassword().getIsValid() && getDomain().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java index 92bac5f..3cab900 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java @@ -555,18 +555,18 @@ } @Override - protected void ItemsChanged() + protected void itemsChanged() { - super.ItemsChanged(); + super.itemsChanged(); ResetIsEmpty(); UpdatePagingAvailability(); } @Override - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { - super.ItemsCollectionChanged(sender, e); + super.itemsCollectionChanged(sender, e); ResetIsEmpty(); UpdatePagingAvailability(); @@ -714,7 +714,7 @@ } } - ItemsChanging(value, items); + itemsChanging(value, items); items = value; UpdatePagingAvailability(); getItemsChangedEvent().raise(this, EventArgs.Empty); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java index 780ae1b..4351ba1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java @@ -95,9 +95,9 @@ { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; - ItemsChanged(); + itemsChanged(); getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java index f1322c3..fd92b0a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java @@ -876,9 +876,9 @@ } @Override - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { - super.ItemsCollectionChanged(sender, e); + super.itemsCollectionChanged(sender, e); // Try to select an item corresponding to the system tree selection. if (getSystemTreeSelectedItem() != null && getSystemTreeSelectedItem().getType() == SystemTreeItemType.Cluster) diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java index 62c8c0a..917a5fd 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java @@ -878,7 +878,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition)) + if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { if (sender == getDataCenter()) { @@ -1056,19 +1056,19 @@ if (validateStoragePool) { - getDataCenter().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getDataCenter().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } if (validateCpu) { - getCPU().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getCPU().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } else { - getCPU().ValidateSelectedItem(new IValidation[] {}); + getCPU().validateSelectedItem(new IValidation[] {}); } - getVersion().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getVersion().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); // TODO: async validation for webadmin // string name = (string)Name.Entity; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java index 6e1436c..e99837c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java @@ -771,9 +771,9 @@ } @Override - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { - super.ItemsCollectionChanged(sender, e); + super.itemsCollectionChanged(sender, e); // Try to select an item corresponding to the system tree selection. if (getSystemTreeSelectedItem() != null diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java index 20d2478..9f0216d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java @@ -179,7 +179,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getStorageTypeList()) + if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getStorageTypeList()) { StorageType_SelectedItemChanged(); } @@ -289,9 +289,9 @@ new LengthValidation(getMaxNameLength()), new AsciiNameValidation() }); - getStorageTypeList().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getStorageTypeList().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); - getVersion().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getVersion().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); getDescription().validateEntity(new IValidation[] { new AsciiOrNoneValidation() }); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java index 809d529..5e42e84 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java @@ -650,16 +650,16 @@ } @Override - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { - super.ItemsCollectionChanged(sender, e); + super.itemsCollectionChanged(sender, e); UpdateActionAvailability(); } @Override - protected void ItemsChanged() + protected void itemsChanged() { - super.ItemsChanged(); + super.itemsChanged(); UpdateActionAvailability(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java index 00aa00d..343d1e7 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java @@ -165,7 +165,7 @@ public void eventRaised(Event ev, Object sender, EventArgs args) { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getDataCenter().getVersion()) { + if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getDataCenter().getVersion()) { DataCenterVersion_SelectedItemChanged(); } else if (ev.matchesDefinition(Frontend.QueryStartedEventDefinition) && StringHelper.stringsEqual(Frontend.getCurrentContext(), frontendHash)) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java index 76f5648..7a36cc1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java @@ -241,8 +241,8 @@ public boolean Validate() { - getNetwork().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); - getBond().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation(), + getNetwork().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getBond().validateSelectedItem(new IValidation[] { new NotEmptyValidation(), new LengthValidation(BusinessEntitiesDefinitions.HOST_NIC_NAME_LENGTH), new BondNameValidation() }); getAddress().setIsValid(true); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java index 141bf1a..9d970a2 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java @@ -165,9 +165,9 @@ { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; - ItemsChanged(); + itemsChanged(); getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java index cfdc84f..00f222c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java @@ -275,7 +275,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getNetwork()) + if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getNetwork()) { Network_SelectedItemChanged(null); } @@ -325,7 +325,7 @@ public boolean Validate() { - getNetwork().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getNetwork().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); getAddress().setIsValid(true); getSubnet().setIsValid(true); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java index 6c778cf..b98189d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java @@ -1600,9 +1600,9 @@ } @Override - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { - super.ItemsCollectionChanged(sender, e); + super.itemsCollectionChanged(sender, e); // Try to select an item corresponding to the system tree selection. if (getSystemTreeSelectedItem() != null && getSystemTreeSelectedItem().getType() == SystemTreeItemType.Host) diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java index 68e7125..c5b4285 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java @@ -294,7 +294,7 @@ public boolean Validate() { - getInterface().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getInterface().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); getAddress().setIsValid(true); getSubnet().setIsValid(true); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java index 759a054..e7e4324 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java @@ -831,11 +831,11 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getDataCenter()) + if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getDataCenter()) { DataCenter_SelectedItemChanged(); } - else if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getCluster()) + else if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getCluster()) { Cluster_SelectedItemChanged(); } else if (sender == getConsoleAddressEnabled()) { @@ -1092,7 +1092,7 @@ { Boolean isPmEnabled = (Boolean) getIsPm().getEntity(); boolean isPrimary = isPmPrimarySelected(); - getCluster().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getCluster().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); ValidatePmModels(isPrimary); if (isPrimary && (!getManagementIp().getIsValid() @@ -1178,7 +1178,7 @@ ip.validateEntity(new IValidation[] {new NotEmptyValidation(), new HostAddressValidation()}); userName.validateEntity(new IValidation[] {new NotEmptyValidation()}); password.validateEntity(new IValidation[] {new NotEmptyValidation()}); - type.ValidateSelectedItem(new IValidation[] {new NotEmptyValidation()}); + type.validateSelectedItem(new IValidation[] {new NotEmptyValidation()}); port.validateEntity(new IValidation[] {new IntegerValidation(1, 65535)}); options.validateEntity(new IValidation[] {new KeyValuePairValidation(true)}); } @@ -1212,8 +1212,8 @@ getConsoleAddress().setIsValid(true); } - getDataCenter().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); - getCluster().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getDataCenter().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getCluster().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); if ((Boolean) getIsPm().getEntity()) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java index 59f0579..fc8d9c7 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java @@ -63,7 +63,7 @@ getRootPassword().setIsValid(true); if (isOVirt) { - getOVirtISO().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getOVirtISO().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } else { getRootPassword().validateEntity(new IValidation[] { new NotEmptyValidation() }); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java index 6e0a30f..be6fadc 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java @@ -117,7 +117,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(SelectedItemChangedEventDefinition) && sender == getCluster()) + if (ev.matchesDefinition(selectedItemChangedEventDefinition) && sender == getCluster()) { Cluster_SelectedItemChanged(); } @@ -125,7 +125,7 @@ public boolean Validate() { - getCluster().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getCluster().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); return getCluster().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java index 6e4839b..bb79a30 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java @@ -332,7 +332,7 @@ boolean isValid = true; for (DiskModel diskModel : getDisks()) { - diskModel.getQuota().ValidateSelectedItem(new IValidation[] { new SelectedQuotaValidation() }); + diskModel.getQuota().validateSelectedItem(new IValidation[] { new SelectedQuotaValidation() }); isValid &= diskModel.getQuota().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java index 6ada2f4..8c7c198 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java @@ -484,7 +484,7 @@ private boolean ValidateDiscoverTargetFields() { - getContainer().getHost().ValidateSelectedItem(new NotEmptyValidation[] { new NotEmptyValidation() }); + getContainer().getHost().validateSelectedItem(new NotEmptyValidation[] { new NotEmptyValidation() }); getAddress().validateEntity(new IValidation[] { new NotEmptyValidation() }); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java index 60446ec..e2cce23 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java @@ -37,7 +37,7 @@ EntityModel lastSelectedItem = (EntityModel) getSelectedItem(); ArrayList<EntityModel> lastSelectedItems = (ArrayList<EntityModel>) getSelectedItems(); - ItemsChanging(value, items); + itemsChanging(value, items); items = value; getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java index b056ebb..01bcf95 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java @@ -1075,9 +1075,9 @@ } @Override - protected void ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) + protected void itemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) { - super.ItemsCollectionChanged(sender, e); + super.itemsCollectionChanged(sender, e); // Try to select an item corresponding to the system tree selection. if (getSystemTreeSelectedItem() != null && getSystemTreeSelectedItem().getType() == SystemTreeItemType.Storage) diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java index 5f8b2da..a552cde 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java @@ -226,7 +226,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(SelectedItemChangedEventDefinition)) + if (ev.matchesDefinition(selectedItemChangedEventDefinition)) { if (sender == getDataCenter()) { @@ -308,9 +308,9 @@ } @Override - protected void ItemsChanged() + protected void itemsChanged() { - super.ItemsChanged(); + super.itemsChanged(); if (getItems() != null) { @@ -747,7 +747,7 @@ else { getHost().setIsValid(true); } - ValidateSelectedItem(new NotEmptyValidation[] { new NotEmptyValidation() }); + validateSelectedItem(new NotEmptyValidation[] { new NotEmptyValidation() }); getDescription().validateEntity(new IValidation[] { new LengthValidation(BusinessEntitiesDefinitions.GENERAL_MAX_SIZE), new SpecialAsciiI18NOrNoneValidation() }); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java index 5760018..5a62c71 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java @@ -116,9 +116,9 @@ { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; - ItemsChanged(); + itemsChanged(); getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ } @@ -206,9 +206,9 @@ } @Override - protected void ItemsChanged() + protected void itemsChanged() { - super.ItemsChanged(); + super.itemsChanged(); if (getSelectionNodeList() != null && getSelectionNodeList().isEmpty() && getAttachedTagsToEntities() != null) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java index aa9c6cc..ac87fcc 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java @@ -105,9 +105,9 @@ if (storageDomainModels != null) { Linq.Sort(storageDomainModels, new StorageDomainModelByNameComparer()); - ItemsChanging(value, items); + itemsChanging(value, items); items = storageDomainModels; - ItemsChanged(); + itemsChanged(); getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ storageDomainModels = null; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java index 577a7eb..c738b46 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java @@ -167,7 +167,7 @@ public void setItems(Iterable value) { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java index 1649cb8..54a324e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java @@ -303,7 +303,7 @@ { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java index acf1f29..8b787e5 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java @@ -313,9 +313,9 @@ } @Override - protected void ItemsChanged() + protected void itemsChanged() { - super.ItemsChanged(); + super.itemsChanged(); UpdateActionAvailability(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionModel.java index 648834f..789f28e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionModel.java @@ -61,7 +61,7 @@ public boolean Validate() { - getRole().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getRole().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); return getRole().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java index 28ee8e2..7011db3 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java @@ -627,7 +627,7 @@ storage_pool dataCenter = (storage_pool) getDataCenter().getSelectedItem(); if (dataCenter != null && dataCenter.getQuotaEnforcementType() == QuotaEnforcementTypeEnum.HARD_ENFORCEMENT) { - getQuota().ValidateSelectedItem(new IValidation[] { new NotEmptyQuotaValidation() }); + getQuota().validateSelectedItem(new IValidation[] { new NotEmptyQuotaValidation() }); } return getAlias().getIsValid() && getDescription().getIsValid() && getQuota().getIsValid(); @@ -731,11 +731,11 @@ { IsInternal_EntityChanged(); } - else if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getVolumeType()) + else if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getVolumeType()) { VolumeType_SelectedItemChanged(); } - else if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition) && sender == getDataCenter()) + else if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getDataCenter()) { Datacenter_SelectedItemChanged(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExportVmModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExportVmModel.java index e90fd85..43a3570 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExportVmModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExportVmModel.java @@ -57,7 +57,7 @@ public boolean Validate() { - getStorage().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getStorage().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); return getStorage().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java index 9266285..58c96fd 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java @@ -505,7 +505,7 @@ public boolean Validate() { if (QuotaEnforcementTypeEnum.HARD_ENFORCEMENT.equals(storagePool.getQuotaEnforcementType())) { - getClusterQuota().ValidateSelectedItem( + getClusterQuota().validateSelectedItem( new IValidation[] { new NotEmptyValidation() }); for (ImportDiskData item : diskImportDataMap.values()) { if (item.getSelectedQuota() == null) { @@ -520,9 +520,9 @@ setMessage(""); } } - getStorage().ValidateSelectedItem( + getStorage().validateSelectedItem( new IValidation[] { new NotEmptyValidation() }); - getCluster().ValidateSelectedItem( + getCluster().validateSelectedItem( new IValidation[] { new NotEmptyValidation() }); return getStorage().getIsValid() diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java index 5ba1ca7..2350b56 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java @@ -227,7 +227,7 @@ sizeValidation.setMaximum((Integer) AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.MaxBlockDiskSize)); } getSize().validateEntity(new IValidation[] { new NotEmptyValidation(), sizeValidation }); - getStorageDomain().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getStorageDomain().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); return super.validate() && getSize().getIsValid() && getStorageDomain().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java index 0b04330..d56f2d9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java @@ -753,7 +753,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition)) + if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { if (sender == getFloppyImage()) { @@ -855,12 +855,12 @@ public boolean Validate() { getIsoImage().setIsValid(true); if ((Boolean) getAttachIso().getEntity()) { - getIsoImage().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getIsoImage().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } getFloppyImage().setIsValid(true); if ((Boolean) getAttachFloppy().getEntity()) { - getFloppyImage().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getFloppyImage().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } boolean customPropertyValidation = getCustomPropertySheet().validate(); @@ -891,7 +891,7 @@ } if (getIsAutoAssign().getEntity() != null && (Boolean) getIsAutoAssign().getEntity() == false) { - getDefaultHost().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getDefaultHost().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } else { getDefaultHost().setIsValid(true); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java index 3c2dcce..917f023 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java @@ -1260,7 +1260,7 @@ { Frontend_QueryComplete(); } - else if (ev.matchesDefinition(ListModel.SelectedItemChangedEventDefinition)) + else if (ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { if (sender == getDataCenter()) { @@ -1938,15 +1938,15 @@ } public boolean Validate() { - getDataCenter().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); - getCluster().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getDataCenter().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getCluster().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); getMemSize().validateEntity(new IValidation[] { new ByteSizeValidation() }); getMinAllocatedMemory().validateEntity(new IValidation[] { new ByteSizeValidation() }); - getOSType().ValidateSelectedItem(new NotEmptyValidation[] { new NotEmptyValidation() }); + getOSType().validateSelectedItem(new NotEmptyValidation[] { new NotEmptyValidation() }); storage_pool dataCenter = (storage_pool) getDataCenter().getSelectedItem(); if (dataCenter != null && dataCenter.getQuotaEnforcementType() == QuotaEnforcementTypeEnum.HARD_ENFORCEMENT) { - getQuota().ValidateSelectedItem(new IValidation[] { new NotEmptyQuotaValidation() }); + getQuota().validateSelectedItem(new IValidation[] { new NotEmptyQuotaValidation() }); } getTotalCPUCores().validateEntity(new IValidation[] { @@ -1983,17 +1983,17 @@ } if (getIsAutoAssign().getEntity() != null && ((Boolean) getIsAutoAssign().getEntity()) == false) { - getDefaultHost().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getDefaultHost().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } else { getDefaultHost().setIsValid(true); } - getTemplate().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getTemplate().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); getDisksAllocationModel().validateEntity(new IValidation[] {}); getCdImage().setIsValid(true); if (getCdImage().getIsChangable()) { - getCdImage().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getCdImage().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); } if (getIsLinuxOS()) { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java index 6015508..acf721c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java @@ -30,9 +30,9 @@ { if (items != value) { - ItemsChanging(value, items); + itemsChanging(value, items); items = value; - ItemsChanged(); + itemsChanged(); getItemsChangedEvent().raise(this, EventArgs.Empty); onPropertyChanged(new PropertyChangedEventArgs("Items")); //$NON-NLS-1$ } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java index 9695321..4d11bc9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java @@ -356,7 +356,7 @@ { getName().validateEntity(new IValidation[] { new NotEmptyValidation(), new I18NNameValidation() }); - getNicType().ValidateSelectedItem(new IValidation[] { new NotEmptyValidation() }); + getNicType().validateSelectedItem(new IValidation[] { new NotEmptyValidation() }); getMAC().setIsValid(true); if (getMAC().getIsChangable()) -- To view, visit http://gerrit.ovirt.org/14183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab6b62a4e9806805b3282ed653ac1e4aa74768e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
