Asaf Shakarchi has posted comments on this change.
Change subject: userportal : User has insufficient permissions on url
/domain/domain_id/user
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDbUsersQuery.java
Line 12: @Override
Line 13: protected void executeQueryCommand() {
Line 14: getQueryReturnValue().setReturnValue(
Line 15: DbFacade.getInstance().getDbUserDao()
Line 16: .getAll());
This query is used by REST api for users retrieval, are you sure no misbehavior
will occur ? adding Michael just in case.
Line 17: }
....................................................
Commit Message
Line 5: CommitDate: 2013-04-23 15:15:01 -0400
Line 6:
Line 7: userportal : User has insufficient permissions on url
/domain/domain_id/user
Line 8:
Line 9: From user portal we should not be able to see alll domain users.
s/alll/all
Line 10: Only those users who have been added to the system need to be
displayed.
Line 11:
Line 12: Change-Id: I2ff611309ec35c4bcca5fcea6457af139c86e8f4
Line 13: Bug-Url: https://bugzilla.redhat.com/923197
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java
Line 20: protected void findUsers(String searchString, AsyncQuery query) {
Line 21: Frontend.RunQuery(VdcQueryType.GetAllDbUsers, new
VdcQueryParametersBase(), getFilteringCallBack());
Line 22: }
Line 23:
Line 24: private AsyncQuery getFilteringCallBack() {
Consider using the standard predicates for filtering instead.
Line 25: AsyncQuery filteringAsyncQuery = new AsyncQuery();
Line 26: filteringAsyncQuery.setModel(this);
Line 27: filteringAsyncQuery.asyncCallback = new INewAsyncCallback() {
Line 28: @Override
--
To view, visit http://gerrit.ovirt.org/14185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff611309ec35c4bcca5fcea6457af139c86e8f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
