Daniel Erez has uploaded a new change for review.

Change subject: webadmin: Disks - sub-tabs resizable columns
......................................................................

webadmin: Disks - sub-tabs resizable columns

Sub-tabs under Disks main-tab now support
resizable columns.

* Invoked enableColumnResizing() on each sub-tab.
* Added a static width value for each column.

Change-Id: Ia6ac016dd8e8428f17c873cd29d7e46170dadcc4
Signed-off-by: Daniel Erez <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
2 files changed, 18 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/14206/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
index c364014..16d2b7c 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java
@@ -38,6 +38,8 @@
     }
 
     void initTable(ApplicationConstants constants) {
+        getTable().enableColumnResizing();
+
         getTable().addColumn(new StorageDomainSharedStatusColumn(), 
constants.empty(), "30px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<StorageDomain> nameColumn = new 
TextColumnWithTooltip<StorageDomain>() {
@@ -46,7 +48,7 @@
                 return object.getStorageName();
             }
         };
-        getTable().addColumn(nameColumn, constants.domainNameStorage());
+        getTable().addColumn(nameColumn, constants.domainNameStorage(), 
"160px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<StorageDomain> typeColumn = new 
EnumColumn<StorageDomain, StorageDomainType>() {
             @Override
@@ -54,7 +56,7 @@
                 return object.getStorageDomainType();
             }
         };
-        getTable().addColumn(typeColumn, constants.domainTypeStorage());
+        getTable().addColumn(typeColumn, constants.domainTypeStorage(), 
"160px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<StorageDomain> statusColumn = new 
EnumColumn<StorageDomain, StorageDomainStatus>() {
             @Override
@@ -62,7 +64,7 @@
                 return object.getStatus();
             }
         };
-        getTable().addColumn(statusColumn, constants.statusStorage());
+        getTable().addColumn(statusColumn, constants.statusStorage(), 
"160px"); //$NON-NLS-1$
 
         DiskSizeColumn<StorageDomain> freeColumn = new 
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
             @Override
@@ -71,7 +73,7 @@
                 return (long) availableDiskSize;
             }
         };
-        getTable().addColumn(freeColumn, constants.freeSpaceStorage());
+        getTable().addColumn(freeColumn, constants.freeSpaceStorage(), 
"160px"); //$NON-NLS-1$
 
         DiskSizeColumn<StorageDomain> usedColumn = new 
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
             @Override
@@ -80,7 +82,7 @@
                 return (long) usedDiskSize;
             }
         };
-        getTable().addColumn(usedColumn, constants.usedSpaceStorage());
+        getTable().addColumn(usedColumn, constants.usedSpaceStorage(), 
"160px"); //$NON-NLS-1$
 
         DiskSizeColumn<StorageDomain> totalColumn = new 
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
             @Override
@@ -89,7 +91,7 @@
                 return (long) totalDiskSize;
             }
         };
-        getTable().addColumn(totalColumn, constants.totalSpaceStorage());
+        getTable().addColumn(totalColumn, constants.totalSpaceStorage(), 
"160px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<StorageDomain> descriptionColumn = new 
TextColumnWithTooltip<StorageDomain>() {
             @Override
@@ -97,7 +99,7 @@
                 return object.getDescription();
             }
         };
-        getTable().addColumn(descriptionColumn, 
constants.domainDescriptionStorage());
+        getTable().addColumn(descriptionColumn, 
constants.domainDescriptionStorage(), "160px"); //$NON-NLS-1$
     }
 
 }
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
index 85c87f8..613e76d 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
@@ -38,6 +38,8 @@
     }
 
     void initTable(final ApplicationConstants constants) {
+        getTable().enableColumnResizing();
+
         ImageResourceColumn<VM> pluggedColumn = new ImageResourceColumn<VM>() {
             @Override
             public ImageResource getValue(VM object) {
@@ -54,7 +56,7 @@
                 return object.getName();
             }
         };
-        getTable().addColumn(nameColumn, constants.nameVm());
+        getTable().addColumn(nameColumn, constants.nameVm(), "160px"); 
//$NON-NLS-1$
 
         getTable().addColumn(new VmTypeColumn(), constants.empty(), "30px"); 
//$NON-NLS-1$
 
@@ -64,7 +66,7 @@
                 return object.getVdsGroupName();
             }
         };
-        getTable().addColumn(clusterColumn, constants.clusterVm());
+        getTable().addColumn(clusterColumn, constants.clusterVm(), "160px"); 
//$NON-NLS-1$
 
         TextColumnWithTooltip<VM> ipColumn = new TextColumnWithTooltip<VM>() {
             @Override
@@ -72,7 +74,7 @@
                 return object.getVmIp();
             }
         };
-        getTable().addColumn(ipColumn, constants.ipVm());
+        getTable().addColumn(ipColumn, constants.ipVm(), "160px"); 
//$NON-NLS-1$
 
         PercentColumn<VM> memColumn = new PercentColumn<VM>() {
             @Override
@@ -80,7 +82,7 @@
                 return object.getUsageMemPercent();
             }
         };
-        getTable().addColumn(memColumn, constants.memoryVm());
+        getTable().addColumn(memColumn, constants.memoryVm(), "160px"); 
//$NON-NLS-1$
 
         PercentColumn<VM> cpuColumn = new PercentColumn<VM>() {
             @Override
@@ -88,7 +90,7 @@
                 return object.getUsageCpuPercent();
             }
         };
-        getTable().addColumn(cpuColumn, constants.cpuVm());
+        getTable().addColumn(cpuColumn, constants.cpuVm(), "160px"); 
//$NON-NLS-1$
 
         PercentColumn<VM> netColumn = new PercentColumn<VM>() {
             @Override
@@ -104,7 +106,7 @@
                 return object.getStatus();
             }
         };
-        getTable().addColumn(statusColumn, constants.statusVm());
+        getTable().addColumn(statusColumn, constants.statusVm(), "160px"); 
//$NON-NLS-1$
 
         TextColumnWithTooltip<VM> hostColumn = new UptimeColumn<VM>() {
             @Override
@@ -112,7 +114,7 @@
                 return object.getRoundedElapsedTime();
             }
         };
-        getTable().addColumn(hostColumn, constants.uptimeVm());
+        getTable().addColumn(hostColumn, constants.uptimeVm(), "160px"); 
//$NON-NLS-1$
     }
 
 }


--
To view, visit http://gerrit.ovirt.org/14206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6ac016dd8e8428f17c873cd29d7e46170dadcc4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to