Maor Lipchuk has posted comments on this change.
Change subject: core: Rename storage_pool entity to StoragePool
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
Line 269: /**
Line 270: * Mock Storage Pool
Line 271: */
Line 272: private StoragePool mockStoragePool() {
Line 273: StoragePool storage_pool = new StoragePool();
better change the variable name as well
Line 274: storage_pool.setstatus(StoragePoolStatus.Up);
Line 275:
Line 276: return storage_pool;
Line 277: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 55: }
Line 56:
Line 57: @SuppressWarnings("unchecked")
Line 58: protected Map<String, String>[]
BuildStructFromConnectionListObject() {
Line 59: final StoragePool storage_pool =
Probably better to change the variable name also to storagePool
Line 60:
DbFacade.getInstance().getStoragePoolDao().getForVds(getParameters().getVdsId());
Line 61: final Map<String, String>[] result = new
HashMap[getParameters().getConnectionList().size()];
Line 62: int i = 0;
Line 63: for (StorageServerConnections connection :
getParameters().getConnectionList()) {
Line 67: return result;
Line 68: }
Line 69:
Line 70: public static Map<String, String> CreateStructFromConnection(final
StorageServerConnections connection,
Line 71: final StoragePool storage_pool) {
same here
Line 72: // for information, see _connectionDict2ConnectionInfo in
vdsm/storage/hsm.py
Line 73: DefaultValueMap con = new DefaultValueMap();
Line 74: con.put("id", connection.getid(), Guid.Empty.toString());
Line 75: con.put("connection", connection.getconnection(), "");
--
To view, visit http://gerrit.ovirt.org/14208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief7f05d7e226e86bf54587e31f1d75cf54a81118
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
