Dan Kenigsberg has posted comments on this change.
Change subject: [wip] core: add the openstack dependency
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1349: GlusterRefreshHeavyWeight(423),
Line 1350:
Line 1351: @TypeConverterAttribute(String.class)
Line 1352: @DefaultValueAttribute("Auto")
Line 1353: KeystoneAuthUrl(424),
Global configuration is generally evil.
Do we really want to limit ourselves to one keystone server for all DCs?
Note that the same keystone infrastructure should be usable for other purposes,
such as http://www.ovirt.org/Features/Detailed_Quantum_Integration
There, we envisaged a "provider" object, with its own authentication. Each
quantum network, or glance storage domain, should have its provider.
Whatever your opinion is, please open this issue to discussion on
[email protected].
Line 1354:
Line 1355: @TypeConverterAttribute(String.class)
Line 1356: @DefaultValueAttribute("Auto")
Line 1357: KeystoneUsername(425),
--
To view, visit http://gerrit.ovirt.org/13434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib516b48ba9c7e3b9bbc657fe970361a484221e88
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
