Alissa Bonas has uploaded a new change for review. Change subject: api: rename method in BackendStorageDomainsResource ......................................................................
api: rename method in BackendStorageDomainsResource Renamed internal method because it was too long and didn't match all the use cases it was dealing with. Change-Id: I862f7da6a9460268f3573f82acbfab68c0f14551 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/14232/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java index b9630af..fbb39fd 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java @@ -75,7 +75,7 @@ return inject(new BackendStorageDomainResource(id, this)); } - private Response addNfsOrLocalOrPosix(VdcActionType action, StorageDomain model, StorageDomainStatic entity, Guid hostId) { + private Response addDomain(VdcActionType action, StorageDomain model, StorageDomainStatic entity, Guid hostId) { StorageServerConnections cnx = mapToCnx(model); entity.setStorage(addStorageServerConnection(cnx, hostId)); @@ -157,7 +157,7 @@ private void connectStorageToHost(Guid hostId, StorageType storageType, LogicalUnit unit) { StorageServerConnections cnx = StorageDomainHelper.getConnection(storageType, unit.getAddress(), unit.getTarget(), unit.getUsername(), unit.getPassword(), unit.getPort()); performAction(VdcActionType.ConnectStorageToVds, - new StorageServerConnectionParametersBase(cnx, hostId)); + new StorageServerConnectionParametersBase(cnx, hostId)); } @Override @@ -176,19 +176,19 @@ break; case NFS: validateParameters(storageDomain.getStorage(), "address", "path"); - resp = addNfsOrLocalOrPosix(VdcActionType.AddNFSStorageDomain, storageDomain, entity, hostId); + resp = addDomain(VdcActionType.AddNFSStorageDomain, storageDomain, entity, hostId); break; case LOCALFS: validateParameters(storageDomain.getStorage(), "path"); - resp = addNfsOrLocalOrPosix(VdcActionType.AddLocalStorageDomain, storageDomain, entity, hostId); + resp = addDomain(VdcActionType.AddLocalStorageDomain, storageDomain, entity, hostId); break; case POSIXFS: validateParameters(storageDomain.getStorage(), "path", "vfsType"); - resp = addNfsOrLocalOrPosix(VdcActionType.AddPosixFsStorageDomain, storageDomain, entity, hostId); + resp = addDomain(VdcActionType.AddPosixFsStorageDomain, storageDomain, entity, hostId); break; case GLUSTERFS: validateParameters(storageDomain.getStorage(), "path", "vfsType"); - resp = addNfsOrLocalOrPosix(VdcActionType.AddGlusterFsStorageDomain, storageDomain, entity, hostId); + resp = addDomain(VdcActionType.AddGlusterFsStorageDomain, storageDomain, entity, hostId); break; default: -- To view, visit http://gerrit.ovirt.org/14232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I862f7da6a9460268f3573f82acbfab68c0f14551 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
