Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: bridge: fix typo in format when querying network manager ......................................................................
vdsm: bridge: fix typo in format when querying network manager Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956602 Change-Id: Id594f22fe49b7def9e278466ce1623e951252f88 Signed-off-by: Alon Bar-Lev <[email protected]> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-host-deploy refs/changes/34/14234/1 diff --git a/ChangeLog b/ChangeLog index 5e53bfd..fe5aebd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,6 +3,8 @@ ????-??-?? - Version 1.1.0 * vdsm: bridge: fix vlan id detection, thanks to Jeff Bailey for reporting. + * vdsm: bridge: fix format typo when querying network manager, thanks to + Pascal Jakobi for reporting. * vdsm: hardware: do not fail if cannot read msr, rhbz#916589. * vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86. diff --git a/src/plugins/ovirt-host-deploy/vdsm/bridge.py b/src/plugins/ovirt-host-deploy/vdsm/bridge.py index 747ee0b..f76c24f 100644 --- a/src/plugins/ovirt-host-deploy/vdsm/bridge.py +++ b/src/plugins/ovirt-host-deploy/vdsm/bridge.py @@ -433,7 +433,7 @@ if dhcp: parameters.append('bootproto=dhcp') elif address is not None: - parameters.append('ipaddr=%s', address) + parameters.append('ipaddr=%s' % address) netmask = socket.inet_ntoa( struct.pack( "!I", @@ -446,8 +446,8 @@ ) ) ) - parameters.append('netmask=%s', netmask) - parameters.append('gateway=%s', gateway) + parameters.append('netmask=%s' % netmask) + parameters.append('gateway=%s' % gateway) else: raise RuntimeError( _('Unsupported network manager configuration') -- To view, visit http://gerrit.ovirt.org/14234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id594f22fe49b7def9e278466ce1623e951252f88 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
