Michael Kublin has posted comments on this change. Change subject: core: inactive domain can be selected as master ......................................................................
Patch Set 5: I would prefer that you didn't submit this After second look on this patch, I can say implementation is completely wrong. The patch will cause insufficient reconstructs in 99%. "When attempting to reconstruct after failure in irs command and there's no domain in Active/Unknown status there will be an attempt to use an inactive domain". - Idea is wrong, why? If no Active/Unknown domain in pool, meaning we have not any host that can see it, no reason for reconstruct. If host is not connected to pool or failed to connect, during spm election we can trigger a reconstruct on InActive domains, but code should look differently -- To view, visit http://gerrit.ovirt.org/13160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9031e2fe0afc161c1a3acdddc9b1e7a58626a159 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
