Kanagaraj M has uploaded a new change for review.

Change subject: webadmin: gluster - subtabs resizable columns
......................................................................

webadmin: gluster - subtabs resizable columns

Invoking enableColumnResizing() in all gluster related subtabs,
and set fixed width for the sub-tab columns.

Change-Id: I923951a0370e9bbddac5a014c7900cfafbdb81c2
Signed-off-by: Kanagaraj M <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeParameterView.java
3 files changed, 16 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/14259/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
index 64b5a60..edfd6c9 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
@@ -31,6 +31,8 @@
     }
 
     void initTable(final ApplicationConstants constants) {
+        getTable().enableColumnResizing();
+
         getTable().addColumn(new GlusterHookSyncStatusColumn(), 
constants.empty(), "10px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<GlusterHookEntity> nameColumn = new 
TextColumnWithTooltip<GlusterHookEntity>() {
@@ -39,7 +41,7 @@
                 return object.getName();
             }
         };
-        getTable().addColumn(nameColumn, constants.nameHook());
+        getTable().addColumn(nameColumn, constants.nameHook(), "200"); 
//$NON-NLS-1$
 
         TextColumnWithTooltip<GlusterHookEntity> glusterCommandColumn = new 
TextColumnWithTooltip<GlusterHookEntity>() {
             @Override
@@ -47,7 +49,7 @@
                 return object.getGlusterCommand();
             }
         };
-        getTable().addColumn(glusterCommandColumn, 
constants.glusterVolumeEventHook());
+        getTable().addColumn(glusterCommandColumn, 
constants.glusterVolumeEventHook(), "100"); //$NON-NLS-1$;
 
         TextColumnWithTooltip<GlusterHookEntity> stageColumn = new 
EnumColumn<GlusterHookEntity, GlusterHookStage>() {
 
@@ -56,7 +58,7 @@
                 return object.getStage();
             }
         };
-        getTable().addColumn(stageColumn, constants.stageHook());
+        getTable().addColumn(stageColumn, constants.stageHook(), "100"); 
//$NON-NLS-1$
 
         TextColumnWithTooltip<GlusterHookEntity> statusColumn = new 
EnumColumn<GlusterHookEntity, GlusterHookStatus>() {
 
@@ -65,7 +67,7 @@
                 return object.getStatus();
             }
         };
-        getTable().addColumn(statusColumn, constants.statusHook());
+        getTable().addColumn(statusColumn, constants.statusHook(), "150"); 
//$NON-NLS-1$
 
         TextColumnWithTooltip<GlusterHookEntity> contentTypeColumn =
                 new EnumColumn<GlusterHookEntity, GlusterHookContentType>() {
@@ -75,7 +77,7 @@
                         return object.getContentType();
                     }
                 };
-        getTable().addColumn(contentTypeColumn, constants.contentTypeHook());
+        getTable().addColumn(contentTypeColumn, constants.contentTypeHook(), 
"150"); //$NON-NLS-1$
 
         getTable().addActionButton(new 
WebAdminButtonDefinition<GlusterHookEntity>(constants.enableHook()) {
             @Override
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
index b98be94..e3d0727 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
@@ -33,13 +33,15 @@
     }
 
     void initTable(ApplicationConstants constants) {
+        getTable().enableColumnResizing();
+
         TextColumnWithTooltip<GlusterBrickEntity> serverColumn = new 
TextColumnWithTooltip<GlusterBrickEntity>() {
             @Override
             public String getValue(GlusterBrickEntity brick) {
                 return brick.getServerName();
             }
         };
-        getTable().addColumn(serverColumn, constants.serverVolumeBrick());
+        getTable().addColumn(serverColumn, constants.serverVolumeBrick(), 
"300px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<GlusterBrickEntity> directoryColumn = new 
TextColumnWithTooltip<GlusterBrickEntity>() {
             @Override
@@ -47,7 +49,7 @@
                 return brick.getBrickDirectory();
             }
         };
-        getTable().addColumn(directoryColumn, 
constants.brickDirectoryVolumeBrick());
+        getTable().addColumn(directoryColumn, 
constants.brickDirectoryVolumeBrick(), "400px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<GlusterBrickEntity> statusColumn =
                 new EnumColumn<GlusterBrickEntity, GlusterStatus>() {
@@ -57,7 +59,7 @@
                         return object.getStatus();
                     }
                 };
-        getTable().addColumn(statusColumn, constants.statusBrick());
+        getTable().addColumn(statusColumn, constants.statusBrick(), "200px"); 
//$NON-NLS-1$
 
         getTable().addActionButton(new 
WebAdminButtonDefinition<GlusterBrickEntity>(constants.addBricksBrick()) {
             @Override
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeParameterView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeParameterView.java
index 4777c07..041b8cf 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeParameterView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeParameterView.java
@@ -31,13 +31,15 @@
     }
 
     void initTable(ApplicationConstants constants) {
+        getTable().enableColumnResizing();
+
         TextColumnWithTooltip<GlusterVolumeOptionEntity> optionKeyColumn = new 
TextColumnWithTooltip<GlusterVolumeOptionEntity>() {
             @Override
             public String getValue(GlusterVolumeOptionEntity option) {
                 return option.getKey();
             }
         };
-        getTable().addColumn(optionKeyColumn, 
constants.optionKeyVolumeParameter());
+        getTable().addColumn(optionKeyColumn, 
constants.optionKeyVolumeParameter(), "400px"); //$NON-NLS-1$
         TextColumnWithTooltip<GlusterVolumeOptionEntity> optionValueColumn =
                 new TextColumnWithTooltip<GlusterVolumeOptionEntity>() {
                     @Override
@@ -45,7 +47,7 @@
                         return option.getValue();
                     }
                 };
-        getTable().addColumn(optionValueColumn, 
constants.optionValueVolumeParameter());
+        getTable().addColumn(optionValueColumn, 
constants.optionValueVolumeParameter(), "400px"); //$NON-NLS-1$;
 
         getTable().addActionButton(new 
WebAdminButtonDefinition<GlusterVolumeOptionEntity>(constants.addVolumeParameter())
 {
             @Override


--
To view, visit http://gerrit.ovirt.org/14259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I923951a0370e9bbddac5a014c7900cfafbdb81c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to